Changes about platform style theme - refs BT#21621 #5614
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5614 +/- ##
============================================
- Coverage 39.07% 39.06% -0.02%
- Complexity 10989 11024 +35
============================================
Files 867 872 +5
Lines 45411 45477 +66
============================================
+ Hits 17746 17767 +21
- Misses 27665 27710 +45 ☔ View full report in Codecov by Sentry. |
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
| */ | ||
| function api_get_visual_theme() | ||
| function api_get_visual_theme(): string |
There was a problem hiding this comment.
Consider putting global function "api_get_visual_theme" in a static class
AngelFQC
force-pushed
the
BT21621_theme
branch
2 times, most recently
from
b671ba8 to
3984206
Compare
AngelFQC
changed the title
| return $this->colorThemes; | ||
| } | ||
|
|
||
| public function addColorTheme(AccessUrlRelColorTheme $colorTheme): static |
There was a problem hiding this comment.
Scope keyword "static" must be followed by a single space
| return $this; | ||
| } | ||
|
|
||
| public function removeColorTheme(AccessUrlRelColorTheme $colorTheme): static |
There was a problem hiding this comment.
Scope keyword "static" must be followed by a single space
AngelFQC
force-pushed
the
BT21621_theme
branch
2 times, most recently
from
3a57e11 to
f0d9e9a
Compare
|
|
||
| /* For licensing terms, see /license.txt */ | ||
|
|
||
| declare(strict_types=1); |
There was a problem hiding this comment.
Add a single space around assignment operators
AngelFQC
force-pushed
the
BT21621_theme
branch
2 times, most recently
from
e346837 to
d186d97
Compare
…eme and migrating the legacy themes - refs BT#21621
…theme/* to var/themes - refs BT#21621
|
Code Climate has analyzed commit 54e6796 and detected 191 issues on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
| @@ -9,30 +9,30 @@ | |||
| <table border="0" cellpadding="0" cellspacing="0"> | |||
| <tr> | |||
| <td colspan="3"> | |||
| <img src="{{ url('index') ~ 'build/css/themes/' ~ stylesheet_name ~ '/images/cuadro.png' }}"> | |||
| <img src="{{ theme_asset('images/cuadre.png') }}"> | |||
There was a problem hiding this comment.
Not sure where cuadre.png or cuadro.png come from. I cannot see them as files in a default installation... (not even in 1.11.x)
There was a problem hiding this comment.
These are the files used for the general certificate from OFAJ (which is custom as indicated in the name of the template).
No description provided.